Suppressed clippy redundant else error in http.rs using expect syntax. Fixes #1095 #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix79-spec
commented
Nov 11, 2025
| let mut server = HttpServer::new(factory); | ||
| #[cfg_attr( | ||
| not(target_family = "unix"), | ||
| expect( |
Contributor
Author
There was a problem hiding this comment.
Used expect instead of allow to make sure this is removed when no longer needed.
Contributor
Author
|
If this wasn't detected in previous test workflows they may need an update so that they run cargo clippy on a windows image to catch issues with suppressed code blocks. |
lovasoa
approved these changes
Nov 12, 2025
Collaborator
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095